fix: Assert expected hooks for restricted method specifications#3993
Merged
Conversation
FrederikBolding
force-pushed
the
fb/assert-hooks-for-restricted-methods
branch
from
cb920dd to
1453f3a
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c9ad72. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3993 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 427 427
Lines 12400 12408 +8
Branches 1948 1949 +1
=======================================
+ Hits 12224 12232 +8
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mrtenz
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert the expected hooks as part of
buildSnapRestrictedMethodSpecificationsto indicate missing or extraneous hooks being passed in to the developer.Note
Medium Risk
Medium risk because it adds strict hook validation in
buildSnapRestrictedMethodSpecifications, which can cause runtime errors for callers passing missing or extra hooks, and updates simulation wiring accordingly.Overview
Adds hook contract enforcement to
buildSnapRestrictedMethodSpecificationsby computing the expectedmethodHooksfrom non-excluded restricted-method builders, callingassertExpectedHooks, and filtering excluded permissions before spec creation.Updates tests to pass the full required hook set and adds coverage ensuring excluded permissions (e.g.,
snap_dialog) are omitted. Adjusts snaps simulation permission spec assembly to pass only the required hooks (includinggetSnapKeyring) and tweaks Jest coverage thresholds.Reviewed by Cursor Bugbot for commit 6640a8d. Bugbot is set up for automated code reviews on this repo. Configure here.